Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for version 2 transactions. #2127

Merged

Conversation

oscarguindzberg
Copy link
Contributor

@oscarguindzberg oscarguindzberg commented Dec 13, 2018

Cherry pick bitcoinj/bitcoinj@850f219
Fixes #1832

Don't merge until:

@ManfredKarrer ManfredKarrer changed the title Basic support for version 2 transactions. [WIP] Basic support for version 2 transactions. Dec 15, 2018
@ManfredKarrer
Copy link
Contributor

I added WIP prefix to make clear that this PR is not ready for merge.

@ManfredKarrer
Copy link
Contributor

The BitcoinJ PR is merged but we would require the libdohJ version update (in both Bisq and libdohJ). We could wait also until libdohJ is removed and we update to 0.14.7 if that is not too far in the future.

@oscarguindzberg oscarguindzberg force-pushed the bisq-version2-tx-support branch from e581272 to b55073c Compare March 1, 2019 03:09
@oscarguindzberg oscarguindzberg changed the title [WIP] Basic support for version 2 transactions. Basic support for version 2 transactions. Mar 1, 2019
@oscarguindzberg
Copy link
Contributor Author

Removed WIP label.
Ready to be merged once #2478 is merged

@ManfredKarrer
Copy link
Contributor

@ripcurlx Lets delay that after release so we keep test efforts low.

@ManfredKarrer ManfredKarrer added this to the v0.9.6 milestone Mar 1, 2019
Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ManfredKarrer ManfredKarrer merged commit 1ef854f into bisq-network:master Mar 6, 2019
@oscarguindzberg oscarguindzberg deleted the bisq-version2-tx-support branch March 11, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants